reaction_detector.py imported FunctionalGroupInfo and MonomerRole from functional_groups_detector, then immediately redefined both classes locally—silently overriding the imports and creating two divergent class hierarchies with identical structure. Any object created by functional_groups_detector would be a different type than one created by reaction_detector, causing subtle isinstance/type-check failures at module boundaries.

Changes

• Deleted the local FunctionalGroupInfo and MonomerRole dataclass definitions from reaction_detector.py
• reaction_detector.py now consumes these types solely via the existing import from functional_groups_detector, which remains the single authoritative definition

# Before: import was immediately shadowed by local redefinitions
try:
    from .functional_groups_detector import FunctionalGroupInfo, MonomerRole
except (ImportError, ModuleNotFoundError):
    from functional_groups_detector import FunctionalGroupInfo, MonomerRole

@dataclass(slots=True, frozen=True)
class FunctionalGroupInfo:   # ← override; creates a separate type
    ...

@dataclass(slots=True, frozen=True)
class MonomerRole:           # ← override; creates a separate type
    ...

# After: imports are the only definitions; local redefinitions removed

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.